Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dv): detail panel not diposing correctly #4308

Merged
merged 2 commits into from
Dec 25, 2024
Merged

fix(dv): detail panel not diposing correctly #4308

merged 2 commits into from
Dec 25, 2024

Conversation

Gggpound
Copy link
Contributor

close https://github.com/dream-num/univer-pro/issues/3598

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2024 •
edited
Loading

Playwright test results

passed  20 passed
flaky  1 flaky

Details

stats  21 tests across 10 suites
duration  4 minutes, 57 seconds
commit  d2c91de
info  For more information, see full report

Flaky tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff facade sheet hooks

@codecov Codecov
Copy link

codecov bot commented Dec 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.37%. Comparing base (862e70b) to head (d2c91de).
Report is 4 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #4308   +/-   ##
=======================================
  Coverage   33.37%   33.37%           
=======================================
  Files        2517     2517           
  Lines      129886   129886           
  Branches    29011    29011           
=======================================
  Hits        43349    43349           
  Misses      86537    86537

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 17, 2024
wzhudev
wzhudev approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev changed the title fix(dv): detail panel effect fix(dv): detail panel not diposing correctly Dec 25, 2024
@wzhudev wzhudev merged commit 0a0e723 into dev Dec 25, 2024
10 checks passed
@wzhudev wzhudev deleted the fix-dv-1214 branch December 25, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weird94 weird94 weird94 approved these changes

@wzhudev wzhudev wzhudev approved these changes

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gggpound @wzhudev @weird94 @zhaolixin7